Browse Source

underscore prefix ignores unused vars; restore code

Martin Kunz 2 months ago
parent
commit
d5bcfd4abe
4 changed files with 27 additions and 23 deletions
  1. 15 1
      .eslintrc.cjs
  2. 1 6
      src/components/TheModeler.vue
  3. 2 2
      src/components/TheParent.vue
  4. 9 14
      src/ua/UABaseNode.ts

+ 15 - 1
.eslintrc.cjs

@@ -10,5 +10,19 @@ module.exports = {
   ],
   parserOptions: {
     ecmaVersion: 'latest'
-  }
+  },
+  rules: {
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        "args": "all",
+        "argsIgnorePattern": "^_",
+        "caughtErrors": "all",
+        "caughtErrorsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+        "ignoreRestSiblings": true
+      }
+    ]
+  },
 }

+ 1 - 6
src/components/TheModeler.vue

@@ -7,11 +7,6 @@ const store = useStore()
 function selectNode(node: UABaseNode) {
   store.selectedNode=node;
 }
-
-function filter() {
-  return false;
-}
-
 </script>
 
 <template>
@@ -24,7 +19,7 @@ function filter() {
           v-if="store.rootNode!=null" 
           :model="store.rootNode" 
           @select-node="(node) => selectNode(node)" 
-          :filter-func="(node:UABaseNode) => filter()">
+          :filter-func="(node:UABaseNode) => {return false}">
         </TreeItem>
       </ul>
     </p>

+ 2 - 2
src/components/TheParent.vue

@@ -13,7 +13,7 @@ const node = computed(() => {
 
 });
 
-function clickNode() {
+function clickNode(node: UABaseNode) {
   //TODO: replace parent references
   // node.value?.setParent(clickedNode, store.addressSpace?.findNode("ns=0;i="+ ReferenceTypeIds.HierarchicalReferences));
   parentDialogOpen.value=false;
@@ -67,7 +67,7 @@ function getRefTypes():UABaseNode[] {
     :open="parentDialogOpen" 
     :filter-func="(node: UABaseNode) => filter(node)"
     @cancel="parentDialogOpen = false" 
-    @select-node="(node) => clickNode()">
+    @select-node="(node) => clickNode(node)">
   </TheTreeDialog>
 </template>
 

+ 9 - 14
src/ua/UABaseNode.ts

@@ -3,14 +3,11 @@ import { coerceNodeId, NodeId } from "./NodeId";
 import { UAReference } from "./UAReference";
 import { assert } from "@/util/assert";
 import { XMLElem, type IToXML } from "@/util/XmlElem";
-import { UARolePermission } from "./UARolePermission"; //TODO
-import { UAExtension } from "./UAExtension"; //TODO
-import { UAUserWriteMask } from "./UAUserWriteMask"; //TODO
-import { UAWriteMask } from "./UAWriteMask"; //TODO
-import { UAAccessRestriction } from "./UAAccessRestriction"; //TODO
-
-
-
+import { UARolePermission } from "./UARolePermission";
+import { UAExtension } from "./UAExtension";
+import { UAUserWriteMask } from "./UAUserWriteMask";
+import { UAWriteMask } from "./UAWriteMask";
+import { UAAccessRestriction } from "./UAAccessRestriction";
 export class UABaseNode implements IToXML{
 
     public nodeId: NodeId;
@@ -62,9 +59,9 @@ export class UABaseNode implements IToXML{
         return null;
     }
 
-    //setParent(node: UABaseNode, refType: String) {
-        
-    //}
+    setParent(node: UABaseNode, refType: String) {
+        //TODO replace parent-like references in both directions.
+    }
 
     getParentRef(): UAReference|null{
         for(const ref of this.references) {
@@ -83,8 +80,6 @@ export class UABaseNode implements IToXML{
         }
         return null;
     }
-    
-
 
     getChildren(): UABaseNode[] {
         const children: UABaseNode[]=[];
@@ -155,7 +150,7 @@ export class UABaseNode implements IToXML{
         return ua;
     }
 
-    toXML(lnst: NamespaceTable, gnst: NamespaceTable): XMLElem {
+    toXML(_lnst: NamespaceTable, _gnst: NamespaceTable): XMLElem {
         throw new Error("UABaseNode has no xml rep; implement in subtype.");
     }