Browse Source

use channel variable after checking for NULL

Julius Pfrommer 7 years ago
parent
commit
e517f1d779
1 changed files with 3 additions and 2 deletions
  1. 3 2
      src/server/ua_services_session.c

+ 3 - 2
src/server/ua_services_session.c

@@ -68,7 +68,6 @@ nonceAndSignCreateSessionResponse(UA_Server *server, UA_SecureChannel *channel,
 void Service_CreateSession(UA_Server *server, UA_SecureChannel *channel,
                            const UA_CreateSessionRequest *request,
                            UA_CreateSessionResponse *response) {
-    UA_LOG_DEBUG_CHANNEL(server->config.logger, channel, "Trying to create session");
     if(channel == NULL) {
         response->responseHeader.serviceResult = UA_STATUSCODE_BADINTERNALERROR;
         return;
@@ -79,6 +78,8 @@ void Service_CreateSession(UA_Server *server, UA_SecureChannel *channel,
         return;
     }
 
+    UA_LOG_DEBUG_CHANNEL(server->config.logger, channel, "Trying to create session");
+
     if(channel->securityMode == UA_MESSAGESECURITYMODE_SIGN ||
        channel->securityMode == UA_MESSAGESECURITYMODE_SIGNANDENCRYPT) {
         if(!UA_ByteString_equal(&request->clientCertificate,
@@ -160,7 +161,7 @@ void Service_CreateSession(UA_Server *server, UA_SecureChannel *channel,
     /* Create a signed nonce */
     response->responseHeader.serviceResult =
         nonceAndSignCreateSessionResponse(server, channel, newSession, request, response);
-    
+
     /* Failure -> remove the session */
     if(response->responseHeader.serviceResult != UA_STATUSCODE_GOOD) {
         UA_SessionManager_removeSession(&server->sessionManager, &newSession->authenticationToken);