Selaa lähdekoodia

valgrind improvements

Julius Pfrommer 10 vuotta sitten
vanhempi
commit
22ce0884af
2 muutettua tiedostoa jossa 4 lisäystä ja 4 poistoa
  1. 2 3
      examples/client_proper.c
  2. 2 1
      src/client/ua_client.c

+ 2 - 3
examples/client_proper.c

@@ -7,7 +7,6 @@
 
 #include "networklayer_tcp.h"
 
-
 int main(int argc, char *argv[]) {
 	UA_Client *client = UA_Client_new();
 	UA_ClientNetworkLayer nl = ClientNetworkLayerTCP_new(UA_ConnectionConfig_standard);
@@ -20,8 +19,8 @@ int main(int argc, char *argv[]) {
     read_req.nodesToRead[0].nodeId = UA_NODEID_STATIC(1, 73);
     read_req.nodesToRead[0].attributeId = UA_ATTRIBUTEID_VALUE;
     UA_ReadResponse read_resp = UA_Client_read(client, &read_req);
-    printf("answer statuscode: %i\n", read_resp.responseHeader.serviceResult);
-    printf("answer value: %i\n", *(UA_Int32*)read_resp.results[0].value.dataPtr);
+    printf("the answer is: %i\n", *(UA_Int32*)read_resp.results[0].value.dataPtr);
+    UA_ReadRequest_deleteMembers(&read_req);
     UA_ReadResponse_deleteMembers(&read_resp);
     UA_Client_delete(client);
 }

+ 2 - 1
src/client/ua_client.c

@@ -78,7 +78,6 @@ UA_StatusCode UA_Client_connect(UA_Client *client, UA_ConnectionConfig conf,
         retval = SecureChannelHandshake(client);
     if(retval == UA_STATUSCODE_GOOD)
         retval = SessionHandshake(client);
-    printf("Connection returned %i\n", retval);
     return retval;
 }
 
@@ -290,6 +289,7 @@ static void synchronousRequest(const void *request, const UA_DataType *requestTy
 
     UA_ByteStringArray buf = {.stringsSize = 1, .strings = &message};
     retval = client->networkLayer.send(client->networkLayer.nlHandle, buf);
+    UA_ByteString_deleteMembers(&message);
     if(retval != UA_STATUSCODE_GOOD) {
         respHeader->serviceResult = retval;
         return;
@@ -345,6 +345,7 @@ static UA_StatusCode SessionHandshake(UA_Client *client) {
                        &response, &UA_TYPES[UA_TYPES_CREATESESSIONRESPONSE],
                        client);
 
+    UA_CreateSessionRequest_deleteMembers(&request);
     UA_CreateSessionResponse_deleteMembers(&response);
     return response.responseHeader.serviceResult; // not deleted
 }