Browse Source

refixed warnings

Leon Urbas 11 years ago
parent
commit
c84b9cc4fc
4 changed files with 219 additions and 188 deletions
  1. 9 9
      tool/generate_builtin.py
  2. 4 4
      tool/generate_namespace.py
  3. 164 136
      tool/opcua_basictypes.c
  4. 42 39
      tool/opcua_basictypes.h

+ 9 - 9
tool/generate_builtin.py

@@ -131,24 +131,24 @@ def createStructured(element):
     if len(valuemap) > 0:
         for n,t in valuemap.iteritems():
             if t.find("**") != -1:
-	        print("\t" + "Int32 " + n + "Size;", end='\n', file=fh)
+	        print("\t" + "UA_Int32 " + n + "Size;", end='\n', file=fh)
             print("\t" + "UA_" + t + " " + n + ";", end='\n', file=fh)
     else:
         print("\t/* null record */", end='\n', file=fh)
         print("\tUA_Int32 NullRecord; /* avoiding warnings */", end='\n', file=fh)
     print("} " + name + ";", end='\n', file=fh)
 
-    print("Int32 " + name + "_calcSize(" + name + " const * ptr);", end='\n', file=fh)
-    print("Int32 " + name + "_encode(" + name + " const * src, Int32* pos, char* dst);", end='\n', file=fh)
-    print("Int32 " + name + "_decode(char const * src, Int32* pos, " + name + "* dst);", end='\n', file=fh)
+    print("UA_Int32 " + name + "_calcSize(" + name + " const * ptr);", end='\n', file=fh)
+    print("UA_Int32 " + name + "_encode(" + name + " const * src, UA_Int32* pos, char* dst);", end='\n', file=fh)
+    print("UA_Int32 " + name + "_decode(char const * src, UA_Int32* pos, " + name + "* dst);", end='\n', file=fh)
 
     if "Response" in name[len(name)-9:]:
 		#Sten: not sure how to get it, actually we need to solve it on a higher level
-        #print("Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn UA_ResponseHeader_getSize()", end='', file=fc)
-		print("Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn 0", end='', file=fc)  
+        #print("UA_Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn UA_ResponseHeader_getSize()", end='', file=fc)
+		print("UA_Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn 0", end='', file=fc)  
     elif "Request" in name[len(name)-9:]:
 		#Sten: dito
-        #print("Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn UA_RequestHeader_getSize()", end='', file=fc) 
+        #print("UA_Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn UA_RequestHeader_getSize()", end='', file=fc) 
 		print("Int32 "  + name + "_calcSize(" + name + " const * ptr) {\n\treturn 0", end='', file=fc) 
     else:
 	# code 
@@ -171,7 +171,7 @@ def createStructured(element):
 
     print("\n\t;\n}\n", end='\n', file=fc)
 
-    print("Int32 "+name+"_encode("+name+" const * src, Int32* pos, char* dst) {\n\tInt32 retval = UA_SUCCESS;", end='\n', file=fc)
+    print("UA_Int32 "+name+"_encode("+name+" const * src, UA_Int32* pos, char* dst) {\n\tUA_Int32 retval = UA_SUCCESS;", end='\n', file=fc)
     # code _encode
     for n,t in valuemap.iteritems():
         if t in elementary_size:
@@ -188,7 +188,7 @@ def createStructured(element):
                 print('\tretval |= UA_'+t+"_encode(&(src->"+n+"),pos,dst);", end='\n', file=fc)
     print("\treturn retval;\n}\n", end='\n', file=fc)
 
-    print("Int32 "+name+"_decode(char const * src, Int32* pos, " + name + "* dst) {\n\tInt32 retval = UA_SUCCESS;", end='\n', file=fc)
+    print("Int32 "+name+"_decode(char const * src, UA_UInt32* pos, " + name + "* dst) {\n\tUA_Int32 retval = UA_SUCCESS;", end='\n', file=fc)
     # code _decode
     for n,t in valuemap.iteritems():
         if t in elementary_size:

+ 4 - 4
tool/generate_namespace.py

@@ -58,15 +58,15 @@ print('''/**********************************************************
 
 #include "opcua.h"  // definition of UA_VTable and basic UA_Types
 
-Int32 UA_toIndex(Int32 id);
+UA_Int32 UA_toIndex(UA_Int32 id);
 extern UA_VTable UA_[]; 
 
 enum UA_VTableIndex_enum {''', end='\n', file=fh)
 
 print('''/* Mapping and vTable of Namespace Zero */
 #include "opcua.h"
-Int32 UA_toIndex(Int32 id) {
-    Int32 retval = -1;
+UA_Int32 UA_toIndex(UA_Int32 id) {
+    UA_Int32 retval = -1;
     switch (id) { ''', end='\n',file=fc)
 
 i = 0
@@ -97,7 +97,7 @@ for row in rows2:
     name = "UA_" + row[0]
     print('#define '+name.upper()+'_NS0 (UA_namespace_zero['+name.upper()+'].Id)', file=fh)
 
-    print("\t{" + row[1] + ", (Int32(*)(void const*)) " + name + "_calcSize, (Int32(*)(char const*,Int32*,void*)) " + name + "_decode, (Int32(*)(void const*,Int32*,char*))" + name + "_encode},",end='\n',file=fc) 
+    print("\t{" + row[1] + ", (UA_Int32(*)(void const*)) " + name + "_calcSize, (UA_Int32(*)(char const*,UA_Int32*,void*)) " + name + "_decode, (UA_Int32(*)(void const*,UA_Int32*,char*))" + name + "_encode},",end='\n',file=fc) 
 
 print("\t{0,UA_NULL,UA_NULL,UA_NULL}\n};",file=fc)
 print('#endif /* OPCUA_NAMESPACE_0_H_ */', end='\n', file=fh)

+ 164 - 136
tool/opcua_basictypes.c

@@ -10,58 +10,85 @@
 #include <string.h>
 
 
+UA_Int32 UA_encode(void* const data, UA_Int32 *pos, UA_Int32 type, char* dst) {
+	return UA_[type].encode(data,pos,dst);
+}
+
+UA_Int32 UA_decode(char* const data, UA_Int32* pos, UA_Int32 type, void* dst){
+	return UA_[type].decode(data,pos,dst);
+}
 
-Int32 UA_calcSize(void* const data, UInt32 type) {
+UA_Int32 UA_calcSize(void* const data, UInt32 type) {
 	return (UA_[type].calcSize)(data);
 }
 
-Int32 UA_Array_calcSize(Int32 nElements, Int32 type, void const ** data) {
+UA_Int32 UA_Array_calcSize(UA_Int32 nElements, UA_Int32 type, void const ** data) {
+
 	int length = sizeof(UA_Int32);
 	int i;
 
+	char** ptr = (char**)data;
+
 	if (nElements > 0) {
-		for(i=0; i<nElements;i++,data++) {
-			length += UA_calcSize(data,type);
+		for(i=0; i<nElements;i++) {
+			length += UA_calcSize((void*)ptr[i],type);
 		}
 	}
 	return length;
 }
-Int32 UA_Array_encode(void const **src, Int32 noElements, Int32 type, Int32* pos, char * dst) {
-	//TODO: Implement
-	return UA_ERR_NOT_IMPLEMENTED;
+UA_Int32 UA_Array_encode(void const **src, UA_Int32 noElements, UA_Int32 type, UA_Int32* pos, char * dst) {
+	UA_Int32 length = sizeof(UA_Int32);
+	UA_Int32 retVal = 0;
+	UA_Int32 i = 0;
+
+	char** ptr = (char**)src;
+
+	UA_Int32_encode(&noElements, pos, dst);
+	for(i=0; i<noElements; i++) {
+		retVal |= UA_[type].encode((void*)src[i], pos, dst);
+	}
+
+	return retVal;
 }
 
-Int32 UA_Array_decode(char const * src, Int32 noElements, Int32 type, Int32* pos, void const **dst) {
-	//TODO: Implement
-	return UA_ERR_NOT_IMPLEMENTED;
+UA_Int32 UA_Array_decode(char const * src,UA_Int32 noElements, UA_Int32 type, UA_Int32* pos, void const **dst) {
+	UA_Int32 length = sizeof(UA_Int32);
+	UA_Int32 retval = 0;
+	UA_Int32 i = 0;
+
+	char** ptr = (char**)src;
+
+	for(i=0; i<noElements; i++) {
+		retval |= UA_[type].decode(src, pos, (void*)dst[i]);
+	}
+	return retval;
 }
 
-Int32 UA_free(void * ptr){
-	printf("UA_free - ptr=%p\n",ptr);
+UA_Int32 UA_free(void * ptr){
 	free(ptr);
 	return UA_SUCCESS;
 }
 
-Int32 UA_alloc(void ** ptr, int size){
+UA_Int32 UA_alloc(void ** ptr, int size){
 	*ptr = malloc(size);
 	printf("UA_alloc - ptr=%p, size=%d\n",*ptr,size);
 	if(*ptr == UA_NULL) return UA_ERR_NO_MEMORY;
 	return UA_SUCCESS;
 }
 
-Int32 UA_memcpy(void * dst, void const * src, int size){
+UA_Int32 UA_memcpy(void * dst, void const * src, int size){
 	memcpy(dst, src, size);
 	return UA_SUCCESS;
 }
 
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Boolean)
-Int32 UA_Boolean_encode(UA_Boolean const * src, Int32* pos, char * dst) {
+UA_Int32 UA_Boolean_encode(UA_Boolean const * src, UA_Int32* pos, char * dst) {
 	UA_Boolean tmpBool = ((*src > 0) ? UA_TRUE : UA_FALSE);
 	memcpy(&(dst[(*pos)++]), &tmpBool, sizeof(UA_Boolean));
 	return UA_SUCCESS;
 }
-Int32 UA_Boolean_decode(char const * src, Int32* pos, UA_Boolean * dst) {
+UA_Int32 UA_Boolean_decode(char const * src, UA_Int32* pos, UA_Boolean * dst) {
 	*dst = ((UA_Boolean) (src[(*pos)++]) > 0) ? UA_TRUE : UA_FALSE;
 	return UA_SUCCESS;
 }
@@ -71,11 +98,11 @@ UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Boolean)
 
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Byte)
-Int32 UA_Byte_encode(UA_Byte const * src, Int32* pos, char * dst) {
+UA_Int32 UA_Byte_encode(UA_Byte const * src, UA_Int32* pos, char * dst) {
 	*dst = src[(*pos)++];
 	return UA_SUCCESS;
 }
-Int32 UA_Byte_decode(char const * src, Int32* pos, UA_Byte * dst) {
+UA_Int32 UA_Byte_decode(char const * src, UA_Int32* pos, UA_Byte * dst) {
 	memcpy(&(dst[(*pos)++]), src, sizeof(UA_Byte));
 	return UA_SUCCESS;
 }
@@ -83,11 +110,11 @@ UA_TYPE_METHOD_DELETE_FREE(UA_Byte)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Byte)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_SByte)
-Int32 UA_SByte_encode(UA_SByte const * src, Int32* pos, char * dst) {
+UA_Int32 UA_SByte_encode(UA_SByte const * src, UA_Int32* pos, char * dst) {
 	dst[(*pos)++] = *src;
 	return UA_SUCCESS;
 }
-Int32 UA_SByte_decode(char const * src, Int32* pos, UA_SByte * dst) {
+UA_Int32 UA_SByte_decode(char const * src, UA_Int32* pos, UA_SByte * dst) {
 	*dst = src[(*pos)++];
 	return 1;
 }
@@ -95,12 +122,12 @@ UA_TYPE_METHOD_DELETE_FREE(UA_SByte)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_SByte)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_UInt16)
-Int32 UA_UInt16_encode(UA_UInt16 const *src, Int32* pos, char * dst) {
+UA_Int32 UA_UInt16_encode(UA_UInt16 const *src, UA_Int32* pos, char * dst) {
 	memcpy(&(dst[*pos]), src, sizeof(UA_UInt16));
 	*pos += sizeof(UA_UInt16);
 	return UA_SUCCESS;
 }
-Int32 UA_UInt16_decode(char const * src, Int32* pos, UA_UInt16* dst) {
+UA_Int32 UA_UInt16_decode(char const * src, UA_Int32* pos, UA_UInt16* dst) {
 	Byte t1 = src[(*pos)++];
 	UInt16 t2 = (UInt16) (src[(*pos)++] << 8);
 	*dst = t1 + t2;
@@ -110,12 +137,12 @@ UA_TYPE_METHOD_DELETE_FREE(UA_UInt16)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_UInt16)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Int16)
-Int32 UA_Int16_encode(UA_Int16 const * src, Int32* pos, char* dst) {
+UA_Int32 UA_Int16_encode(UA_Int16 const * src, UA_Int32* pos, char* dst) {
 	memcpy(&(dst[*pos]), src, sizeof(UA_Int16));
 	*pos += sizeof(UA_Int16);
 	return UA_SUCCESS;
 }
-Int32 UA_Int16_decode(char const * src, Int32* pos, UA_Int16 *dst) {
+UA_Int32 UA_Int16_decode(char const * src, UA_Int32* pos, UA_Int16 *dst) {
 	Int16 t1 = (Int16) (((SByte) (src[(*pos)++]) & 0xFF));
 	Int16 t2 = (Int16) (((SByte) (src[(*pos)++]) & 0xFF) << 8);
 	*dst = t1 + t2;
@@ -125,16 +152,16 @@ UA_TYPE_METHOD_DELETE_FREE(UA_Int16)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Int16)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Int32)
-Int32 UA_Int32_encode(UA_Int32 const * src, Int32* pos, char *dst) {
+UA_Int32 UA_Int32_encode(UA_Int32 const * src, UA_Int32* pos, char *dst) {
 	memcpy(&(dst[*pos]), src, sizeof(UA_Int32));
 	*pos += sizeof(UA_Int32);
 	return UA_SUCCESS;
 }
-Int32 UA_Int32_decode(char const * src, Int32* pos, UA_Int32* dst) {
-	Int32 t1 = (Int32) (((SByte) (src[(*pos)++]) & 0xFF));
-	Int32 t2 = (Int32) (((SByte) (src[(*pos)++]) & 0xFF) << 8);
-	Int32 t3 = (Int32) (((SByte) (src[(*pos)++]) & 0xFF) << 16);
-	Int32 t4 = (Int32) (((SByte) (src[(*pos)++]) & 0xFF) << 24);
+UA_Int32 UA_Int32_decode(char const * src, UA_Int32* pos, UA_Int32* dst) {
+	UA_Int32 t1 = (UA_Int32) (((SByte) (src[(*pos)++]) & 0xFF));
+	UA_Int32 t2 = (UA_Int32) (((SByte) (src[(*pos)++]) & 0xFF) << 8);
+	UA_Int32 t3 = (UA_Int32) (((SByte) (src[(*pos)++]) & 0xFF) << 16);
+	UA_Int32 t4 = (UA_Int32) (((SByte) (src[(*pos)++]) & 0xFF) << 24);
 	*dst = t1 + t2 + t3 + t4;
 	return UA_SUCCESS;
 }
@@ -142,12 +169,12 @@ UA_TYPE_METHOD_DELETE_FREE(UA_Int32)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Int32)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_UInt32)
-Int32 UA_UInt32_encode(UA_UInt32 const * src, Int32* pos, char *dst) {
+UA_Int32 UA_UInt32_encode(UA_UInt32 const * src, UA_Int32* pos, char *dst) {
 	memcpy(&(dst[*pos]), src, sizeof(UA_UInt32));
 	*pos += sizeof(UA_UInt32);
 	return UA_SUCCESS;
 }
-Int32 UA_UInt32_decode(char const * src, Int32* pos, UA_UInt32 *dst) {
+UA_Int32 UA_UInt32_decode(char const * src, UA_Int32* pos, UA_UInt32 *dst) {
 	UInt32 t1 = (UInt32) src[(*pos)++];
 	UInt32 t2 = (UInt32) src[(*pos)++] << 8;
 	UInt32 t3 = (UInt32) src[(*pos)++] << 16;
@@ -159,12 +186,12 @@ UA_TYPE_METHOD_DELETE_FREE(UA_UInt32)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_UInt32)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Int64)
-Int32 UA_Int64_encode(UA_Int64 const * src, Int32* pos, char *dst) {
+UA_Int32 UA_Int64_encode(UA_Int64 const * src, UA_Int32* pos, char *dst) {
 	memcpy(&(dst[*pos]), src, sizeof(UA_Int64));
 	*pos += sizeof(UA_Int64);
 	return UA_SUCCESS;
 }
-Int32 UA_Int64_decode(char const * src, Int32* pos, UA_Int64* dst) {
+UA_Int32 UA_Int64_decode(char const * src, UA_Int32* pos, UA_Int64* dst) {
 	Int64 t1 = (Int64) src[(*pos)++];
 	Int64 t2 = (Int64) src[(*pos)++] << 8;
 	Int64 t3 = (Int64) src[(*pos)++] << 16;
@@ -180,12 +207,12 @@ UA_TYPE_METHOD_DELETE_FREE(UA_Int64)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Int64)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_UInt64)
-Int32 UA_UInt64_encode(UA_UInt64 const * src , Int32* pos, char * dst) {
+UA_Int32 UA_UInt64_encode(UA_UInt64 const * src , UA_Int32* pos, char * dst) {
 	memcpy(&(dst[*pos]), src, sizeof(UA_UInt64));
 	*pos += sizeof(UInt64);
 	return UA_SUCCESS;
 }
-Int32 UA_UInt64_decode(char const * src, Int32* pos, UA_UInt64* dst) {
+UA_Int32 UA_UInt64_decode(char const * src, UA_Int32* pos, UA_UInt64* dst) {
 	UInt64 t1 = (UInt64) src[(*pos)++];
 	UInt64 t2 = (UInt64) src[(*pos)++] << 8;
 	UInt64 t3 = (UInt64) src[(*pos)++] << 16;
@@ -201,13 +228,13 @@ UA_TYPE_METHOD_DELETE_FREE(UA_UInt64)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_UInt64)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Float)
-Int32 UA_Float_decode(char const * src, Int32* pos, UA_Float* dst) {
+UA_Int32 UA_Float_decode(char const * src, UA_Int32* pos, UA_Float* dst) {
 	// TODO: not yet implemented
 	memcpy(dst, &(src[*pos]), sizeof(UA_Float));
 	*pos += sizeof(UA_Float);
 	return UA_SUCCESS;
 }
-Int32 UA_Float_encode(UA_Float const * src, Int32* pos, char *dst) {
+UA_Int32 UA_Float_encode(UA_Float const * src, UA_Int32* pos, char *dst) {
 	// TODO: not yet implemented
 	memcpy(&(dst[*pos]), src, sizeof(UA_Float));
 	*pos += sizeof(UA_Float);
@@ -217,7 +244,7 @@ UA_TYPE_METHOD_DELETE_FREE(UA_Float)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Float)
 
 UA_TYPE_METHOD_CALCSIZE_SIZEOF(UA_Double)
-Int32 UA_Double_decode(char const * src, Int32* pos, UA_Double * dst) {
+UA_Int32 UA_Double_decode(char const * src, UA_Int32* pos, UA_Double * dst) {
 	// TODO: not yet implemented
 	Double tmpDouble;
 	tmpDouble = (Double) (src[*pos]);
@@ -225,7 +252,7 @@ Int32 UA_Double_decode(char const * src, Int32* pos, UA_Double * dst) {
 	*dst = tmpDouble;
 	return UA_SUCCESS;
 }
-Int32 UA_Double_encode(UA_Double const * src, Int32 *pos, char * dst) {
+UA_Int32 UA_Double_encode(UA_Double const * src, UA_Int32 *pos, char * dst) {
 	// TODO: not yet implemented
 	memcpy(&(dst[*pos]), src, sizeof(UA_Double));
 	*pos *= sizeof(UA_Double);
@@ -234,7 +261,7 @@ Int32 UA_Double_encode(UA_Double const * src, Int32 *pos, char * dst) {
 UA_TYPE_METHOD_DELETE_FREE(UA_Double)
 UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(UA_Double)
 
-Int32 UA_String_calcSize(UA_String const * string) {
+UA_Int32 UA_String_calcSize(UA_String const * string) {
 	if (string == UA_NULL) {
 		// internal size for UA_memalloc
 		return sizeof(UA_String);
@@ -247,7 +274,7 @@ Int32 UA_String_calcSize(UA_String const * string) {
 		}
 	}
 }
-Int32 UA_String_encode(UA_String const * src, Int32* pos, char *dst) {
+UA_Int32 UA_String_encode(UA_String const * src, UA_Int32* pos, char *dst) {
 	UA_Int32_encode(&(src->length),pos,dst);
 
 	if (src->length > 0) {
@@ -256,8 +283,8 @@ Int32 UA_String_encode(UA_String const * src, Int32* pos, char *dst) {
 	}
 	return UA_SUCCESS;
 }
-Int32 UA_String_decode(char const * src, Int32* pos, UA_String * dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_String_decode(char const * src, UA_Int32* pos, UA_String * dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_Int32_decode(src,pos,&(dst->length));
 	if (dst->length > 0) {
 		retval |= UA_alloc((void**)&(dst->data),dst->length);
@@ -269,9 +296,9 @@ Int32 UA_String_decode(char const * src, Int32* pos, UA_String * dst) {
 	return retval;
 }
 UA_TYPE_METHOD_DELETE_STRUCT(UA_String)
-Int32 UA_String_deleteMembers(UA_String* p) { return UA_free(p->data); }
-Int32 UA_String_copy(UA_String const * src, UA_String* dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_String_deleteMembers(UA_String* p) { return UA_free(p->data); }
+UA_Int32 UA_String_copy(UA_String const * src, UA_String* dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	dst->length = src->length;
 	dst->data = UA_NULL;
 	if (src->length > 0) {
@@ -293,7 +320,7 @@ UA_TYPE_METHOD_DECODE_AS(UA_ByteString, UA_String)
 UA_TYPE_METHOD_DELETE_AS(UA_ByteString, UA_String)
 UA_TYPE_METHOD_DELETEMEMBERS_AS(UA_ByteString, UA_String)
 
-Int32 UA_Guid_calcSize(UA_Guid const * p) {
+UA_Int32 UA_Guid_calcSize(UA_Guid const * p) {
 	if (p == UA_NULL) {
 		return sizeof(UA_Guid);
 	} else {
@@ -305,16 +332,16 @@ Int32 UA_Guid_calcSize(UA_Guid const * p) {
 		;
 	}
 }
-Int32 UA_Guid_encode(UA_Guid const *src, Int32* pos, char *dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_Guid_encode(UA_Guid const *src, UA_Int32* pos, char *dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_UInt32_encode(&(src->data1), pos, dst);
 	retval |= UA_UInt16_encode(&(src->data2), pos, dst);
 	retval |= UA_UInt16_encode(&(src->data3), pos, dst);
 	retval |= UA_ByteString_encode(&(src->data4), pos, dst);
 	return UA_SUCCESS;
 }
-Int32 UA_Guid_decode(char const * src, Int32* pos, UA_Guid *dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_Guid_decode(char const * src, UA_Int32* pos, UA_Guid *dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_UInt32_decode(src,pos,&(dst->data1));
 	retval |= UA_UInt16_decode(src,pos,&(dst->data2));
 	retval |= UA_UInt16_decode(src,pos,&(dst->data3));
@@ -322,10 +349,10 @@ Int32 UA_Guid_decode(char const * src, Int32* pos, UA_Guid *dst) {
 	return retval;
 }
 UA_TYPE_METHOD_DELETE_STRUCT(UA_Guid)
-Int32 UA_Guid_deleteMembers(UA_Guid* p) { return UA_ByteString_delete(&(p->data4)); }
+UA_Int32 UA_Guid_deleteMembers(UA_Guid* p) { return UA_ByteString_delete(&(p->data4)); }
 
-Int32 UA_LocalizedText_calcSize(UA_LocalizedText const * p) {
-	Int32 length = 0;
+UA_Int32 UA_LocalizedText_calcSize(UA_LocalizedText const * p) {
+	UA_Int32 length = 0;
 	if (p==UA_NULL) {
 		// size for UA_memalloc
 		length = sizeof(UA_LocalizedText);
@@ -341,9 +368,9 @@ Int32 UA_LocalizedText_calcSize(UA_LocalizedText const * p) {
 	}
 	return length;
 }
-Int32 UA_LocalizedText_encode(UA_LocalizedText const * src, Int32 *pos,
+UA_Int32 UA_LocalizedText_encode(UA_LocalizedText const * src, UA_Int32 *pos,
 		char * dst) {
-	Int32 retval = UA_SUCCESS;
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_Byte_encode(&(src->encodingMask),pos,dst);
 	if (src->encodingMask & 0x01) {
 		UA_String_encode(&(src->locale),pos,dst);
@@ -353,9 +380,9 @@ Int32 UA_LocalizedText_encode(UA_LocalizedText const * src, Int32 *pos,
 	}
 	return retval;
 }
-Int32 UA_LocalizedText_decode(char const * src, Int32 *pos,
+UA_Int32 UA_LocalizedText_decode(char const * src, UA_Int32 *pos,
 		UA_LocalizedText *dst) {
-	Int32 retval = UA_SUCCESS;
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_String_copy(&UA_String_null,&(dst->locale));
 	retval |= UA_String_copy(&UA_String_null,&(dst->text));
 
@@ -369,7 +396,7 @@ Int32 UA_LocalizedText_decode(char const * src, Int32 *pos,
 	return retval;
 }
 UA_TYPE_METHOD_DELETE_STRUCT(UA_LocalizedText)
-Int32 UA_LocalizedText_deleteMembers(UA_LocalizedText* p) {
+UA_Int32 UA_LocalizedText_deleteMembers(UA_LocalizedText* p) {
 	return UA_SUCCESS
 			|| UA_String_deleteMembers(&(p->locale))
 			|| UA_String_deleteMembers(&(p->text))
@@ -377,8 +404,8 @@ Int32 UA_LocalizedText_deleteMembers(UA_LocalizedText* p) {
 }
 
 /* Serialization of UA_NodeID is specified in 62541-6, §5.2.2.9 */
-Int32 UA_NodeId_calcSize(UA_NodeId const *p) {
-	Int32 length = 0;
+UA_Int32 UA_NodeId_calcSize(UA_NodeId const *p) {
+	UA_Int32 length = 0;
 	if (p == UA_NULL) {
 		length = sizeof(UA_NodeId);
 	} else {
@@ -407,7 +434,7 @@ Int32 UA_NodeId_calcSize(UA_NodeId const *p) {
 	}
 	return length;
 }
-Int32 UA_NodeId_encode(UA_NodeId const * src, Int32* pos, char *dst) {
+UA_Int32 UA_NodeId_encode(UA_NodeId const * src, UA_Int32* pos, char *dst) {
 	// temporary variables for endian-save code
 	UA_Byte srcByte;
 	UA_UInt16 srcUInt16;
@@ -444,7 +471,7 @@ Int32 UA_NodeId_encode(UA_NodeId const * src, Int32* pos, char *dst) {
 	}
 	return retval;
 }
-Int32 UA_NodeId_decode(char const * src, Int32* pos, UA_NodeId *dst) {
+UA_Int32 UA_NodeId_decode(char const * src, UA_Int32* pos, UA_NodeId *dst) {
 	int retval = UA_SUCCESS;
 	// temporary variables to overcome decoder's non-endian-saveness for datatypes
 	UA_Byte   dstByte;
@@ -483,7 +510,7 @@ Int32 UA_NodeId_decode(char const * src, Int32* pos, UA_NodeId *dst) {
 	return retval;
 }
 UA_TYPE_METHOD_DELETE_STRUCT(UA_NodeId)
-Int32 UA_NodeId_deleteMembers(UA_NodeId* p) {
+UA_Int32 UA_NodeId_deleteMembers(UA_NodeId* p) {
 	int retval = UA_SUCCESS;
 	switch (p->encodingByte) {
 	case UA_NodeIdType_TwoByte:
@@ -506,8 +533,8 @@ Int32 UA_NodeId_deleteMembers(UA_NodeId* p) {
 //FIXME: Sten Where do these two flags come from?
 #define NIEVT_NAMESPACE_URI_FLAG 0x80 	//Is only for ExpandedNodeId required
 #define NIEVT_SERVERINDEX_FLAG 0x40 //Is only for ExpandedNodeId required
-Int32 UA_ExpandedNodeId_calcSize(UA_ExpandedNodeId const * p) {
-	Int32 length = 0;
+UA_Int32 UA_ExpandedNodeId_calcSize(UA_ExpandedNodeId const * p) {
+	UA_Int32 length = 0;
 	if (p == UA_NULL) {
 		length = sizeof(UA_ExpandedNodeId);
 	} else {
@@ -521,7 +548,7 @@ Int32 UA_ExpandedNodeId_calcSize(UA_ExpandedNodeId const * p) {
 	}
 	return length;
 }
-Int32 UA_ExpandedNodeId_encode(UA_ExpandedNodeId const * src, Int32* pos, char *dst) {
+UA_Int32 UA_ExpandedNodeId_encode(UA_ExpandedNodeId const * src, UA_Int32* pos, char *dst) {
 	UInt32 retval = UA_SUCCESS;
 	retval |= UA_NodeId_encode(&(src->nodeId),pos,dst);
 	if (src->nodeId.encodingByte & NIEVT_NAMESPACE_URI_FLAG) {
@@ -532,7 +559,7 @@ Int32 UA_ExpandedNodeId_encode(UA_ExpandedNodeId const * src, Int32* pos, char *
 	}
 	return retval;
 }
-Int32 UA_ExpandedNodeId_decode(char const * src, Int32* pos,
+UA_Int32 UA_ExpandedNodeId_decode(char const * src, UA_Int32* pos,
 		UA_ExpandedNodeId *dst) {
 	UInt32 retval = UA_SUCCESS;
 	retval |= UA_NodeId_decode(src,pos,&(dst->nodeId));
@@ -549,15 +576,15 @@ Int32 UA_ExpandedNodeId_decode(char const * src, Int32* pos,
 	return retval;
 }
 UA_TYPE_METHOD_DELETE_STRUCT(UA_ExpandedNodeId)
-Int32 UA_ExpandedNodeId_deleteMembers(UA_ExpandedNodeId* p) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_ExpandedNodeId_deleteMembers(UA_ExpandedNodeId* p) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_NodeId_deleteMembers(&(p->nodeId));
 	retval |= UA_String_deleteMembers(&(p->namespaceUri));
 	return retval;
 }
 
-Int32 UA_ExtensionObject_calcSize(UA_ExtensionObject const * p) {
-	Int32 length = 0;
+UA_Int32 UA_ExtensionObject_calcSize(UA_ExtensionObject const * p) {
+	UA_Int32 length = 0;
 	if (p == UA_NULL) {
 		length = sizeof(UA_ExtensionObject);
 	} else {
@@ -577,31 +604,31 @@ Int32 UA_ExtensionObject_calcSize(UA_ExtensionObject const * p) {
 	}
 	return length;
 }
-Int32 UA_ExtensionObject_encode(UA_ExtensionObject const *src, Int32* pos, char * dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_ExtensionObject_encode(UA_ExtensionObject const *src, UA_Int32* pos, char * dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_NodeId_encode(&(src->typeId),pos,dst);
 	retval |= UA_Byte_encode(&(src->encoding),pos,dst);
 	switch (src->encoding) {
-	case NO_BODY_IS_ENCODED:
+	case UA_ExtensionObject_NoBodyIsEncoded:
 		break;
-	case BODY_IS_BYTE_STRING:
-	case BODY_IS_XML_ELEMENT:
+	case UA_ExtensionObject_BodyIsByteString:
+	case UA_ExtensionObject_BodyIsXml:
 		retval |= UA_ByteString_encode(&(src->body),pos,dst);
 		break;
 	}
 	return retval;
 }
-Int32 UA_ExtensionObject_decode(char const * src, Int32 *pos,
+UA_Int32 UA_ExtensionObject_decode(char const * src, UA_Int32 *pos,
 		UA_ExtensionObject *dst) {
-	Int32 retval = UA_SUCCESS;
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_NodeId_decode(src,pos,&(dst->typeId));
 	retval |= UA_Byte_decode(src,pos,&(dst->encoding));
 	retval |= UA_String_copy(&UA_String_null, (UA_String*) &(dst->body));
 	switch (dst->encoding) {
-	case NO_BODY_IS_ENCODED:
+	case UA_ExtensionObject_NoBodyIsEncoded:
 		break;
-	case BODY_IS_BYTE_STRING:
-	case BODY_IS_XML_ELEMENT:
+	case UA_ExtensionObject_BodyIsByteString:
+	case UA_ExtensionObject_BodyIsXml:
 		retval |= UA_ByteString_decode(src,pos,&(dst->body));
 		break;
 	}
@@ -609,8 +636,8 @@ Int32 UA_ExtensionObject_decode(char const * src, Int32 *pos,
 }
 
 UA_TYPE_METHOD_DELETE_STRUCT(UA_ExtensionObject)
-Int32 UA_ExtensionObject_deleteMembers(UA_ExtensionObject *p) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_ExtensionObject_deleteMembers(UA_ExtensionObject *p) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_NodeId_deleteMembers(&(p->typeId));
 	retval |= UA_ByteString_deleteMembers(&(p->body));
 	return retval;
@@ -622,33 +649,34 @@ Int32 UA_ExtensionObject_deleteMembers(UA_ExtensionObject *p) {
 // TODO: UA_DataValue_deleteMembers
 
 /** DiagnosticInfo - Part: 4, Chapter: 7.9, Page: 116 */
-Int32 UA_DiagnosticInfo_decode(char const * src, Int32 *pos, UA_DiagnosticInfo *dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_DiagnosticInfo_decode(char const * src, UA_Int32 *pos, UA_DiagnosticInfo *dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	int i;
 
 	retval |= UA_Byte_decode(src, pos, &(dst->encodingMask));
 
 	for (i = 0; i < 7; i++) {
 		switch ( (0x01 << i) & dst->encodingMask)  {
-		case DIEMT_SYMBOLIC_ID:
+
+		case UA_DiagnosticInfoEncodingMaskType_SymbolicId:
 			 retval |= UA_Int32_decode(src, pos, &(dst->symbolicId));
 			break;
-		case DIEMT_NAMESPACE:
+		case UA_DiagnosticInfoEncodingMaskType_Namespace:
 			retval |= UA_Int32_decode(src, pos, &(dst->namespaceUri));
 			break;
-		case DIEMT_LOCALIZED_TEXT:
+		case UA_DiagnosticInfoEncodingMaskType_LocalizedText:
 			retval |= UA_Int32_decode(src, pos, &(dst->localizedText));
 			break;
-		case DIEMT_LOCALE:
+		case UA_DiagnosticInfoEncodingMaskType_Locale:
 			retval |= UA_Int32_decode(src, pos, &(dst->locale));
 			break;
-		case DIEMT_ADDITIONAL_INFO:
+		case UA_DiagnosticInfoEncodingMaskType_AdditionalInfo:
 			retval |= UA_String_decode(src, pos, &(dst->additionalInfo));
 			break;
-		case DIEMT_INNER_STATUS_CODE:
+		case UA_DiagnosticInfoEncodingMaskType_InnerStatusCode:
 			retval |= UA_StatusCode_decode(src, pos, &(dst->innerStatusCode));
 			break;
-		case DIEMT_INNER_DIAGNOSTIC_INFO:
+		case UA_DiagnosticInfoEncodingMaskType_InnerDiagnosticInfo:
 			// innerDiagnosticInfo is a pointer to struct, therefore allocate
 			retval |= UA_alloc((void **) &(dst->innerDiagnosticInfo),UA_DiagnosticInfo_calcSize(UA_NULL));
 			retval |= UA_DiagnosticInfo_decode(src, pos, dst->innerDiagnosticInfo);
@@ -657,41 +685,41 @@ Int32 UA_DiagnosticInfo_decode(char const * src, Int32 *pos, UA_DiagnosticInfo *
 	}
 	return retval;
 }
-Int32 UA_DiagnosticInfo_encode(UA_DiagnosticInfo const *src, Int32 *pos, char *dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_DiagnosticInfo_encode(UA_DiagnosticInfo const *src, UA_Int32 *pos, char *dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	Byte mask;
 	int i;
 
 	UA_Byte_encode(&(src->encodingMask), pos, dst);
 	for (i = 0; i < 7; i++) {
 		switch ( (0x01 << i) & src->encodingMask)  {
-		case DIEMT_SYMBOLIC_ID:
+		case UA_DiagnosticInfoEncodingMaskType_SymbolicId:
 			retval |= UA_Int32_encode(&(src->symbolicId), pos, dst);
 			break;
-		case DIEMT_NAMESPACE:
+		case UA_DiagnosticInfoEncodingMaskType_Namespace:
 			retval |=  UA_Int32_encode( &(src->namespaceUri), pos, dst);
 			break;
-		case DIEMT_LOCALIZED_TEXT:
+		case UA_DiagnosticInfoEncodingMaskType_LocalizedText:
 			retval |= UA_Int32_encode(&(src->localizedText), pos, dst);
 			break;
-		case DIEMT_LOCALE:
+		case UA_DiagnosticInfoEncodingMaskType_Locale:
 			retval |= UA_Int32_encode(&(src->locale), pos, dst);
 			break;
-		case DIEMT_ADDITIONAL_INFO:
+		case UA_DiagnosticInfoEncodingMaskType_AdditionalInfo:
 			retval |= UA_String_encode(&(src->additionalInfo), pos, dst);
 			break;
-		case DIEMT_INNER_STATUS_CODE:
+		case UA_DiagnosticInfoEncodingMaskType_InnerStatusCode:
 			retval |= UA_StatusCode_encode(&(src->innerStatusCode), pos, dst);
 			break;
-		case DIEMT_INNER_DIAGNOSTIC_INFO:
+		case UA_DiagnosticInfoEncodingMaskType_InnerDiagnosticInfo:
 			retval |= UA_DiagnosticInfo_encode(src->innerDiagnosticInfo, pos, dst);
 			break;
 		}
 	}
 	return retval;
 }
-Int32 UA_DiagnosticInfo_calcSize(UA_DiagnosticInfo const * ptr) {
-	Int32 length = 0;
+UA_Int32 UA_DiagnosticInfo_calcSize(UA_DiagnosticInfo const * ptr) {
+	UA_Int32 length = 0;
 	if (ptr == UA_NULL) {
 		length = sizeof(UA_DiagnosticInfo);
 	} else {
@@ -701,26 +729,26 @@ Int32 UA_DiagnosticInfo_calcSize(UA_DiagnosticInfo const * ptr) {
 		for (mask = 0x01; mask <= 0x40; mask *= 2) {
 			switch (mask & (ptr->encodingMask)) {
 
-			case DIEMT_SYMBOLIC_ID:
+			case UA_DiagnosticInfoEncodingMaskType_SymbolicId:
 				//	puts("diagnosticInfo symbolic id");
 				length += sizeof(UA_Int32);
 				break;
-			case DIEMT_NAMESPACE:
+			case UA_DiagnosticInfoEncodingMaskType_Namespace:
 				length += sizeof(UA_Int32);
 				break;
-			case DIEMT_LOCALIZED_TEXT:
+			case UA_DiagnosticInfoEncodingMaskType_LocalizedText:
 				length += sizeof(UA_Int32);
 				break;
-			case DIEMT_LOCALE:
+			case UA_DiagnosticInfoEncodingMaskType_Locale:
 				length += sizeof(UA_Int32);
 				break;
-			case DIEMT_ADDITIONAL_INFO:
+			case UA_DiagnosticInfoEncodingMaskType_AdditionalInfo:
 				length += UA_String_calcSize(&(ptr->additionalInfo));
 				break;
-			case DIEMT_INNER_STATUS_CODE:
+			case UA_DiagnosticInfoEncodingMaskType_InnerStatusCode:
 				length += sizeof(UA_StatusCode);
 				break;
-			case DIEMT_INNER_DIAGNOSTIC_INFO:
+			case UA_DiagnosticInfoEncodingMaskType_InnerDiagnosticInfo:
 				length += UA_DiagnosticInfo_calcSize(ptr->innerDiagnosticInfo);
 				break;
 			}
@@ -729,9 +757,9 @@ Int32 UA_DiagnosticInfo_calcSize(UA_DiagnosticInfo const * ptr) {
 	return length;
 }
 UA_TYPE_METHOD_DELETE_STRUCT(UA_DiagnosticInfo)
-Int32 UA_DiagnosticInfo_deleteMembers(UA_DiagnosticInfo *p) {
-	Int32 retval = UA_SUCCESS;
-	if (p->encodingMask & DIEMT_INNER_DIAGNOSTIC_INFO) {
+UA_Int32 UA_DiagnosticInfo_deleteMembers(UA_DiagnosticInfo *p) {
+	UA_Int32 retval = UA_SUCCESS;
+	if (p->encodingMask & UA_DiagnosticInfoEncodingMaskType_InnerDiagnosticInfo) {
 		retval |= UA_DiagnosticInfo_deleteMembers(p->innerDiagnosticInfo);
 		retval |= UA_free(p->innerDiagnosticInfo);
 	}
@@ -764,24 +792,24 @@ UA_TYPE_METHOD_DECODE_AS(UA_StatusCode, UA_UInt32)
 UA_TYPE_METHOD_DELETE_AS(UA_StatusCode, UA_UInt32)
 UA_TYPE_METHOD_DELETEMEMBERS_AS(UA_StatusCode, UA_UInt32)
 
-Int32 UA_QualifiedName_calcSize(UA_QualifiedName const * p) {
-	Int32 length = 0;
+UA_Int32 UA_QualifiedName_calcSize(UA_QualifiedName const * p) {
+	UA_Int32 length = 0;
 	length += sizeof(UInt16); //qualifiedName->namespaceIndex
 	length += sizeof(UInt16); //qualifiedName->reserved
 	length += UA_String_calcSize(&(p->name)); //qualifiedName->name
 	return length;
 }
-Int32 UA_QualifiedName_decode(char const * src, Int32 *pos,
+UA_Int32 UA_QualifiedName_decode(char const * src, UA_Int32 *pos,
 		UA_QualifiedName *dst) {
-	Int32 retval = UA_SUCCESS;
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_UInt16_decode(src,pos,&(dst->namespaceIndex));
 	retval |= UA_UInt16_decode(src,pos,&(dst->reserved));
 	retval |= UA_String_decode(src,pos,&(dst->name));
 	return retval;
 }
-Int32 UA_QualifiedName_encode(UA_QualifiedName const *src, Int32* pos,
+UA_Int32 UA_QualifiedName_encode(UA_QualifiedName const *src, UA_Int32* pos,
 		char *dst) {
-	Int32 retval = UA_SUCCESS;
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_UInt16_encode(&(src->namespaceIndex),pos,dst);
 	retval |= UA_UInt16_encode(&(src->reserved),pos,dst);
 	retval |= UA_String_encode(&(src->name),pos,dst);
@@ -789,9 +817,9 @@ Int32 UA_QualifiedName_encode(UA_QualifiedName const *src, Int32* pos,
 }
 
 
-Int32 UA_Variant_calcSize(UA_Variant const * p) {
-	Int32 length = 0;
-	Int32 ns0Id = p->encodingMask & 0x1F; // Bits 1-5
+UA_Int32 UA_Variant_calcSize(UA_Variant const * p) {
+	UA_Int32 length = 0;
+	UA_Int32 ns0Id = p->encodingMask & 0x1F; // Bits 1-5
 	Boolean isArray = p->encodingMask & (0x01 << 7); // Bit 7
 	Boolean hasDimensions = p->encodingMask & (0x01 << 6); // Bit 6
 	int i;
@@ -801,7 +829,7 @@ Int32 UA_Variant_calcSize(UA_Variant const * p) {
 	}
 	length += sizeof(Byte); //p->encodingMask
 	if (isArray) { // array length is encoded
-		length += sizeof(Int32); //p->arrayLength
+		length += sizeof(UA_Int32); //p->arrayLength
 		if (p->arrayLength > 0) {
 			// TODO: add suggestions of @jfpr to not iterate over arrays with fixed len elements
 			for (i=0;i<p->arrayLength;i++) {
@@ -816,8 +844,8 @@ Int32 UA_Variant_calcSize(UA_Variant const * p) {
 	}
 	return length;
 }
-Int32 UA_Variant_encode(UA_Variant const *src, Int32* pos, char *dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_Variant_encode(UA_Variant const *src, UA_Int32* pos, char *dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	int i;
 
 	if (src->vt == UA_NULL || src->encodingMask != src->vt->Id) {
@@ -842,9 +870,9 @@ Int32 UA_Variant_encode(UA_Variant const *src, Int32* pos, char *dst) {
 	return retval;
 }
 
-Int32 UA_Variant_decode(char const * src, Int32 *pos, UA_Variant *dst) {
-	Int32 retval = UA_SUCCESS;
-	Int32 ns0Id;
+UA_Int32 UA_Variant_decode(char const * src, UA_Int32 *pos, UA_Variant *dst) {
+	UA_Int32 retval = UA_SUCCESS;
+	UA_Int32 ns0Id;
 	int i;
 
 	retval |= UA_Byte_decode(src,pos,&(dst->encodingMask));
@@ -884,8 +912,8 @@ Int32 UA_Variant_decode(char const * src, Int32 *pos, UA_Variant *dst) {
 
 //TODO: place this define at the server configuration
 #define MAX_PICO_SECONDS 1000
-Int32 UA_DataValue_decode(char const * src, Int32* pos, UA_DataValue* dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_DataValue_decode(char const * src, UA_Int32* pos, UA_DataValue* dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_Byte_decode(src,pos,&(dst->encodingMask));
 	if (dst->encodingMask & 0x01) {
 		retval |= UA_Variant_decode(src,pos,&(dst->value));
@@ -913,8 +941,8 @@ Int32 UA_DataValue_decode(char const * src, Int32* pos, UA_DataValue* dst) {
 	}
 	return retval;
 }
-Int32 UA_DataValue_encode(UA_DataValue const * src, Int32* pos, char *dst) {
-	Int32 retval = UA_SUCCESS;
+UA_Int32 UA_DataValue_encode(UA_DataValue const * src, UA_Int32* pos, char *dst) {
+	UA_Int32 retval = UA_SUCCESS;
 	retval |= UA_Byte_encode(&(src->encodingMask),pos,dst);
 	if (src->encodingMask & 0x01) {
 		retval |= UA_Variant_encode(&(src->value),pos,dst);
@@ -937,8 +965,8 @@ Int32 UA_DataValue_encode(UA_DataValue const * src, Int32* pos, char *dst) {
 	return retval;
 }
 
-Int32 UA_DataValue_calcSize(UA_DataValue const * p) {
-	Int32 length = 0;
+UA_Int32 UA_DataValue_calcSize(UA_DataValue const * p) {
+	UA_Int32 length = 0;
 
 	if (p == UA_NULL) {	// get static storage size
 		length = sizeof(UA_DataValue);

+ 42 - 39
tool/opcua_basictypes.h

@@ -38,59 +38,62 @@ typedef double Double;
 #define UA_FALSE (!UA_TRUE)
 #define FALSE UA_FALSE
 
+// This is the standard return value, need to have this definition here to make the macros work
+typedef int32_t UA_Int32;
+
 /* heap memory functions */
-Int32 UA_free(void * ptr);
-Int32 UA_memcpy(void *dst, void const *src, int size);
-Int32 UA_alloc(void ** dst, int size);
+UA_Int32 UA_free(void * ptr);
+UA_Int32 UA_memcpy(void *dst, void const *src, int size);
+UA_Int32 UA_alloc(void ** dst, int size);
 
 /* Array operations */
-Int32 UA_Array_calcSize(Int32 noElements, Int32 type, void const ** ptr);
-Int32 UA_Array_encode(void const **src, Int32 noElements, Int32 type, Int32* pos, char * dst);
-Int32 UA_Array_decode(char const * src, Int32 noElements, Int32 type, Int32* pos, void const **dst);
-
+UA_Int32 UA_Array_calcSize(UA_Int32 noElements, UA_Int32 type, void const ** ptr);
+UA_Int32 UA_Array_encode(void const **src, UA_Int32 noElements, UA_Int32 type, UA_Int32* pos, char * dst);
+UA_Int32 UA_Array_decode(char const * src,UA_Int32 noElements, UA_Int32 type, UA_Int32* pos, void const **dst);
 #define UA_NULL ((void*)0)
 // #define NULL UA_NULL
 
 #define UA_TYPE_METHOD_PROTOTYPES(TYPE) \
-Int32 TYPE##_calcSize(TYPE const * ptr);\
-Int32 TYPE##_encode(TYPE const * src, Int32* pos, char * dst);\
-Int32 TYPE##_decode(char const * src, Int32* pos, TYPE * dst);\
-Int32 TYPE##_delete(TYPE * p);\
-Int32 TYPE##_deleteMembers(TYPE * p); \
+UA_Int32 TYPE##_calcSize(TYPE const * ptr);\
+UA_Int32 TYPE##_encode(TYPE const * src, UA_Int32* pos, char * dst);\
+UA_Int32 TYPE##_decode(char const * src, UA_Int32* pos, TYPE * dst);\
+UA_Int32 TYPE##_delete(TYPE * p);\
+UA_Int32 TYPE##_deleteMembers(TYPE * p); \
+
 
 #define UA_TYPE_METHOD_CALCSIZE_SIZEOF(TYPE) \
-Int32 TYPE##_calcSize(TYPE const * p) { return sizeof(TYPE); }
+UA_Int32 TYPE##_calcSize(TYPE const * p) { return sizeof(TYPE); }
 
 #define UA_TYPE_METHOD_CALCSIZE_AS(TYPE, TYPE_AS) \
-Int32 TYPE##_calcSize(TYPE const * p) { return TYPE_AS##_calcSize((TYPE_AS*) p); }
+UA_Int32 TYPE##_calcSize(TYPE const * p) { return TYPE_AS##_calcSize((TYPE_AS*) p); }
 
 #define UA_TYPE_METHOD_DELETE_FREE(TYPE) \
-Int32 TYPE##_delete(TYPE * p) { return UA_free(p); }
+UA_Int32 TYPE##_delete(TYPE * p) { return UA_free(p); }
 
 #define UA_TYPE_METHOD_DELETE_AS(TYPE, TYPE_AS) \
-Int32 TYPE##_delete(TYPE * p) { return TYPE_AS##_delete((TYPE_AS*) p);}
+UA_Int32 TYPE##_delete(TYPE * p) { return TYPE_AS##_delete((TYPE_AS*) p);}
 
 #define UA_TYPE_METHOD_DELETE_STRUCT(TYPE) \
-Int32 TYPE##_delete(TYPE *p) { \
-	Int32 retval = UA_SUCCESS; \
+UA_Int32 TYPE##_delete(TYPE *p) { \
+	UA_Int32 retval = UA_SUCCESS; \
 	retval |= TYPE##_deleteMembers(p); \
 	retval |= UA_free(p); \
 	return retval; \
 }
 
 #define UA_TYPE_METHOD_DELETEMEMBERS_NOACTION(TYPE) \
-Int32 TYPE##_deleteMembers(TYPE * p) { return UA_SUCCESS; }
+UA_Int32 TYPE##_deleteMembers(TYPE * p) { return UA_SUCCESS; }
 
 #define UA_TYPE_METHOD_DELETEMEMBERS_AS(TYPE, TYPE_AS) \
-Int32 TYPE##_deleteMembers(TYPE * p) { return TYPE_AS##_deleteMembers((TYPE_AS*) p);}
+UA_Int32 TYPE##_deleteMembers(TYPE * p) { return TYPE_AS##_deleteMembers((TYPE_AS*) p);}
 
 #define UA_TYPE_METHOD_DECODE_AS(TYPE,TYPE_AS) \
-Int32 TYPE##_decode(char const * src, Int32* pos, TYPE *dst) { \
+UA_Int32 TYPE##_decode(char const * src, UA_Int32* pos, TYPE *dst) { \
 	return TYPE_AS##_decode(src,pos,(TYPE_AS*) dst); \
 }
 
 #define UA_TYPE_METHOD_ENCODE_AS(TYPE,TYPE_AS) \
-Int32 TYPE##_encode(TYPE const * src, Int32* pos, char *dst) { \
+UA_Int32 TYPE##_encode(TYPE const * src, UA_Int32* pos, char *dst) { \
 	return TYPE_AS##_encode((TYPE_AS*) src,pos,dst); \
 }
 
@@ -110,10 +113,11 @@ UA_TYPE_METHOD_PROTOTYPES (UA_Int16)
 typedef uint16_t UA_UInt16;
 UA_TYPE_METHOD_PROTOTYPES (UA_UInt16)
 
-typedef int32_t UA_Int32;
+
+/* typedef int32_t UA_Int32; // see typedef above */
 UA_TYPE_METHOD_PROTOTYPES (UA_Int32)
 
-typedef uint32_t UA_UInt32;
+typedef int32_t UA_UInt32;
 UA_TYPE_METHOD_PROTOTYPES (UA_UInt32)
 
 typedef int64_t UA_Int64;
@@ -149,9 +153,9 @@ UA_TYPE_METHOD_PROTOTYPES (UA_IntegerId)
 
 typedef struct T_UA_VTable {
 	UA_UInt32 Id;
-	Int32 (*calcSize)(void const * ptr);
-	Int32 (*decode)(char const * src, Int32* pos, void* dst);
-	Int32 (*encode)(void const * src, Int32* pos, char* dst);
+	UA_Int32 (*calcSize)(void const * ptr);
+	UA_Int32 (*decode)(char const * src, UA_Int32* pos, void* dst);
+	UA_Int32 (*encode)(void const * src, UA_Int32* pos, char* dst);
 } UA_VTable;
 
 /* VariantBinaryEncoding - Part: 6, Chapter: 5.2.2.16, Page: 22 */
@@ -250,11 +254,12 @@ typedef struct T_UA_ExtensionObject {
 	UA_ByteString body;
 } UA_ExtensionObject;
 UA_TYPE_METHOD_PROTOTYPES(UA_ExtensionObject)
+
 enum UA_ExtensionObject_EncodingMaskType_enum
 {
-	NO_BODY_IS_ENCODED = 	0x00,
-	BODY_IS_BYTE_STRING = 	0x01,
-	BODY_IS_XML_ELEMENT = 	0x02
+	UA_ExtensionObject_NoBodyIsEncoded = 	0x00,
+	UA_ExtensionObject_BodyIsByteString = 	0x01,
+	UA_ExtensionObject_BodyIsXml = 	0x02
 };
 
 /* QualifiedNameBinaryEncoding - Part: 6, Chapter: 5.2.2.13, Page: 20 */
@@ -292,15 +297,13 @@ UA_TYPE_METHOD_PROTOTYPES(UA_DiagnosticInfo)
 
 enum UA_DiagnosticInfoEncodingMaskType_enum
 {
-	// Some Values are called the same as previous Enumerations so we need
-	//names that are unique
-	DIEMT_SYMBOLIC_ID = 			0x01,
-	DIEMT_NAMESPACE = 				0x02,
-	DIEMT_LOCALIZED_TEXT = 			0x04,
-	DIEMT_LOCALE = 					0x08,
-	DIEMT_ADDITIONAL_INFO = 		0x10,
-	DIEMT_INNER_STATUS_CODE = 		0x20,
-	DIEMT_INNER_DIAGNOSTIC_INFO = 	0x40
+	UA_DiagnosticInfoEncodingMaskType_SymbolicId = 			0x01,
+	UA_DiagnosticInfoEncodingMaskType_Namespace = 			0x02,
+	UA_DiagnosticInfoEncodingMaskType_LocalizedText = 		0x04,
+	UA_DiagnosticInfoEncodingMaskType_Locale = 				0x08,
+	UA_DiagnosticInfoEncodingMaskType_AdditionalInfo = 		0x10,
+	UA_DiagnosticInfoEncodingMaskType_InnerStatusCode = 	0x20,
+	UA_DiagnosticInfoEncodingMaskType_InnerDiagnosticInfo = 0x40
 };
 
 #endif /* OPCUA_BASICTYPES_H_ */