Browse Source

Check for null pointer access

See: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7298

Credit to oss-fuzz
Stefan Profanter 6 years ago
parent
commit
d4025369c0
1 changed files with 2 additions and 0 deletions
  1. 2 0
      src/server/ua_server_ns0.c

+ 2 - 0
src/server/ua_server_ns0.c

@@ -495,6 +495,8 @@ readMonitoredItems(UA_Server *server, const UA_NodeId *sessionId, void *sessionC
     UA_Session *session = UA_SessionManager_getSessionById(&server->sessionManager, sessionId);
     if(!session)
         return UA_STATUSCODE_BADINTERNALERROR;
+    if (inputSize == 0 || !input[0].data)
+        return UA_STATUSCODE_BADSUBSCRIPTIONIDINVALID;
     UA_UInt32 subscriptionId = *((UA_UInt32*)(input[0].data));
     UA_Subscription* subscription = UA_Session_getSubscriptionById(session, subscriptionId);
     if(!subscription)