Add a valgrind suppression for a glibc bug; enable valgrind for all tests

tests/CMakeLists.txt

@@ -33,18 +33,16 @@ set(test_plugin_sources ${PROJECT_SOURCE_DIR}/plugins/ua_network_tcp.c
 add_library(open62541-testplugins OBJECT ${test_plugin_sources})
 add_dependencies(open62541-testplugins open62541)
 
-# Workaround some clang warnings in the uni tests
+# Workaround some clang warnings in the unit tests
 if(CMAKE_COMPILER_IS_GNUCC OR "x${CMAKE_C_COMPILER_ID}" STREQUAL "xClang")
     add_definitions(-Wno-sign-conversion)
 endif()
 
 # Unit Test Definition Macro
-# TODO: Re-enable all valgrind tests when travis uses a libc without the freeaddrinfo bug
-# Probably this: https://bugzilla.redhat.com/show_bug.cgi?id=754026
 set(VALGRIND_FLAGS --quiet --trace-children=yes --leak-check=full)
 macro(add_test_valgrind TEST_NAME)
     if(UA_ENABLE_VALGRIND_UNIT_TESTS)
-        add_test(${TEST_NAME} valgrind --error-exitcode=1 ${VALGRIND_FLAGS} ${ARGN})
+        add_test(${TEST_NAME} valgrind --error-exitcode=1 --suppressions=${PROJECT_SOURCE_DIR}/tools/valgrind_suppressions.supp ${VALGRIND_FLAGS} ${ARGN})
     else()
         add_test(${TEST_NAME} ${ARGN})
     endif()
@@ -79,10 +77,9 @@ add_test_valgrind(check_utils ${TESTS_BINARY_DIR}/check_utils)
 
 # Test Server
 
-# TODO: Re-enable valgrind test
 add_executable(check_services_view check_services_view.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
 target_link_libraries(check_services_view ${LIBS})
-add_test(services_view ${TESTS_BINARY_DIR}/check_services_view)
+add_test_valgrind(services_view ${TESTS_BINARY_DIR}/check_services_view)
 
 add_executable(check_services_attributes check_services_attributes.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
 target_link_libraries(check_services_attributes ${LIBS})
@@ -113,10 +110,9 @@ target_link_libraries(check_server_userspace ${LIBS})
 add_test_valgrind(check_server_userspace ${TESTS_BINARY_DIR}/check_server_userspace)
 
 if(UA_ENABLE_DISCOVERY)
-    # TODO: Re-enable valgrind test
     add_executable(check_discovery check_discovery.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
     target_link_libraries(check_discovery ${LIBS})
-    add_test(discovery ${TESTS_BINARY_DIR}/check_discovery)
+    add_test_valgrind(discovery ${TESTS_BINARY_DIR}/check_discovery)
 endif()
 
 # Readspeed server
@@ -175,22 +171,18 @@ add_test_valgrind(check_server_binary_messages_write ${TESTS_BINARY_DIR}/check_s
 
 # Test Client
 
-# TODO: Re-enable valgrind test
 add_executable(check_client check_client.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
 target_link_libraries(check_client ${LIBS})
-add_test(check_client ${TESTS_BINARY_DIR}/check_client)
+add_test_valgrind(check_client ${TESTS_BINARY_DIR}/check_client)
 
-# TODO: Re-enable valgrind test
 add_executable(check_client_async check_client_async.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
 target_link_libraries(check_client_async ${LIBS})
-add_test(check_client_async ${TESTS_BINARY_DIR}/check_client_async)
+add_test_valgrind(check_client_async ${TESTS_BINARY_DIR}/check_client_async)
 
-# TODO: Re-enable valgrind test
 add_executable(check_client_subscriptions check_client_subscriptions.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
 target_link_libraries(check_client_subscriptions ${LIBS})
-add_test(check_client_subscriptions ${TESTS_BINARY_DIR}/check_client_subscriptions)
+add_test_valgrind(check_client_subscriptions ${TESTS_BINARY_DIR}/check_client_subscriptions)
 
-# TODO: Re-enable valgrind test
 add_executable(check_client_highlevel check_client_highlevel.c $<TARGET_OBJECTS:open62541-object> $<TARGET_OBJECTS:open62541-testplugins>)
 target_link_libraries(check_client_highlevel ${LIBS})
-add_test(check_client_highlevel ${TESTS_BINARY_DIR}/check_client_highlevel)
+add_test_valgrind(check_client_highlevel ${TESTS_BINARY_DIR}/check_client_highlevel)

tests/check_services_subscriptions.c

@@ -56,7 +56,6 @@ START_TEST(Server_modifySubscription) {
     request.requestedMaxKeepAliveCount = 1000;
     request.maxNotificationsPerPublish = 1;
     request.priority = 10;
-        
 
     UA_ModifySubscriptionResponse response;
     UA_ModifySubscriptionResponse_init(&response);
@@ -100,7 +99,6 @@ START_TEST(Server_republish) {
     ck_assert_uint_eq(response.responseHeader.serviceResult, UA_STATUSCODE_BADMESSAGENOTAVAILABLE);
 
     UA_RepublishResponse_deleteMembers(&response);
-
 }
 END_TEST
 
@@ -118,7 +116,6 @@ START_TEST(Server_republish_invalid) {
     ck_assert_uint_eq(response.responseHeader.serviceResult, UA_STATUSCODE_BADSUBSCRIPTIONIDINVALID);
 
     UA_RepublishResponse_deleteMembers(&response);
-
 }
 END_TEST
 
@@ -197,7 +194,6 @@ START_TEST(Server_publishCallback) {
 END_TEST
 
 START_TEST(Server_createMonitoredItems) {
-
     UA_CreateMonitoredItemsRequest request;
     UA_CreateMonitoredItemsRequest_init(&request);
     request.subscriptionId = subscriptionId;
@@ -217,7 +213,6 @@ START_TEST(Server_createMonitoredItems) {
     request.itemsToCreateSize = 1;
     request.itemsToCreate = &item;
 
-
     UA_CreateMonitoredItemsResponse response;
     UA_CreateMonitoredItemsResponse_init(&response);
 
@@ -229,7 +224,6 @@ START_TEST(Server_createMonitoredItems) {
     monitoredItemId = response.results[0].monitoredItemId;
 
     UA_MonitoredItemCreateRequest_deleteMembers(&item);
-
     UA_CreateMonitoredItemsResponse_deleteMembers(&response);
 }
 END_TEST
@@ -253,7 +247,6 @@ START_TEST(Server_modifyMonitoredItems) {
     request.itemsToModifySize = 1;
     request.itemsToModify = &item;
 
-
     UA_ModifyMonitoredItemsResponse response;
     UA_ModifyMonitoredItemsResponse_init(&response);
 
@@ -263,7 +256,6 @@ START_TEST(Server_modifyMonitoredItems) {
     ck_assert_uint_eq(response.results[0].statusCode, UA_STATUSCODE_GOOD);
 
     UA_MonitoredItemModifyRequest_deleteMembers(&item);
-
     UA_ModifyMonitoredItemsResponse_deleteMembers(&response);
 }
 END_TEST
@@ -284,7 +276,6 @@ START_TEST(Server_setMonitoringMode) {
     ck_assert_uint_eq(response.resultsSize, 1);
     ck_assert_uint_eq(response.results[0], UA_STATUSCODE_GOOD);
 
-
     UA_SetMonitoringModeResponse_deleteMembers(&response);
 }
 END_TEST
@@ -304,7 +295,6 @@ START_TEST(Server_deleteMonitoredItems) {
     ck_assert_uint_eq(response.resultsSize, 1);
     ck_assert_uint_eq(response.results[0], UA_STATUSCODE_GOOD);
 
-
     UA_DeleteMonitoredItemsResponse_deleteMembers(&response);
 
 }

tools/valgrind_suppressions.supp

@@ -0,0 +1,10 @@
+# Probably this: https://bugzilla.redhat.com/show_bug.cgi?id=754026
+{
+   <glibc noai6ai_cached>
+   Memcheck:Free
+   fun:free
+   fun:__libc_freeres
+   fun:_vgnU_freeres
+   fun:__run_exit_handlers
+   fun:exit
+}